Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update plugin with latest from https://github.com/qjebbs/vscode-plantuml #78

Closed
wants to merge 5 commits into from

Conversation

c835722
Copy link

@c835722 c835722 commented Nov 18, 2017

Thank you for this plugin. Its works well for me (when I run it in with all other plugins disabled).
There is a bug (that was fixed recently) in the base plugin that prevents the plugin failing (which is what this plugin is currently doing for me when other plugins are enabled)
Could you please update this version to pull the fix from #68 commit 247c84d.
Cheers.

@c835722
Copy link
Author

c835722 commented Nov 18, 2017

Sorry. That didnt quite work out as I expected.
I wanted the fork to be updated from the base.
Will try to undo this confusion.

@c835722
Copy link
Author

c835722 commented Nov 18, 2017

It appears the forked repo does not allow issues.
@jkeys089 could you consider pulling this change to your fork.

@c835722
Copy link
Author

c835722 commented Nov 18, 2017

Thanks @jkeys089 . I assume there is some lag now where the vs-code marketplace pulls and builds your change before it is published and available to a user given an uninstall and re-install of the plugin does not yet contain the change ...

@jkeys089
Copy link

@c835722 after fighting a bit with typescript and vsce I finally was able to publish an updated version with this fix. Thanks for pointing it out!

@c835722
Copy link
Author

c835722 commented Nov 18, 2017

Thank you @jkeys089 .

@c835722 c835722 closed this Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants