Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Python 3.12.0 specific usage #1341

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

woodsp-ibm
Copy link
Member

Summary

Closes #1327

It seems that the breaking change that caused test failure in 3.12.1, that had us pin to 3.12.0, has been reverted in 3.12.2. While the testtools has been fixed to accommodate that change, it has not yet had a release with the update in it, but given the change in Python has been reverted its no longer needed presently.

Details and comments

Will need Branch Rules updating (again!)

@woodsp-ibm woodsp-ibm added type: ci Related to CI changes stable backport potential The bug might be minimal and/or import enough to be port to stable labels Feb 22, 2024
@woodsp-ibm woodsp-ibm mentioned this pull request Feb 22, 2024
2 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8007063531

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.758%

Totals Coverage Status
Change from base Build 7974977964: 0.0%
Covered Lines: 8786
Relevant Lines: 10127

💛 - Coveralls

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrossinek mrossinek merged commit a7d9253 into qiskit-community:main Feb 22, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request Feb 22, 2024
@woodsp-ibm woodsp-ibm deleted the unpin_3_12_0 branch February 22, 2024 15:57
woodsp-ibm added a commit that referenced this pull request Feb 22, 2024
(cherry picked from commit a7d9253)

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci Related to CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.12 support
3 participants