Issue 45 q components sort filter #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved this commit from my last PR #938 to a new one. Sorry for the mistake. |
|
To get linting to pass, save your python files with yapf formatting. |
|
Good Morning, |
Run yapf on all files plus a few method updates in the filter/sort logic.
|
You can make a draft pull request, which will run the github actions for tests. |
|
https://github.com/Qiskit/qiskit-metal/blob/main/.pylintrc Look at line 17 and 18 If these are autogenerated, the files need to be added here. |
|
Hi. Tested in Windows 10. |
priti-ashvin-shah-ibm
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
#45
Did you add tests to cover your changes (yes/no)?
No. This is a UI bug fix.
Did you update the documentation accordingly (yes/no)?
No. This is a UI bug fix.
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
The QComponents table now has a QSortFilterProxyModel (see screen shots), you can now sort the table and filter using the text box.
Details and comments
Good Morning,
A fix for #45
The QComponents table now has a QSortFilterProxyModel as shown in the screen shots, you can now sort the table and filter using the text box.