Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note for ElmerFEM for Windows (#933) #934

Conversation

sirshisram
Copy link
Contributor

What are the issues this pull addresses (issue numbers / links)?

#933

Did you add tests to cover your changes (yes/no)?

Yes, can be checked on #933 and on #metal

Did you update the documentation accordingly (yes/no)?

Yes.

Did you read the CONTRIBUTING document (yes/no)?

Yes.

Summary

  • Added a note for ElmerFEM for Windows.

Details and comments

Installing ElmerFEM-gui-mpi-Windows-AMD64 instead of ElmerFEM-gui-nompi-Windows-AMD64 solved an issue of running ElmerGrid on the input mesh from Gmsh.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2023

CLA assistant check
All committers have signed the CLA.

@priti-ashvin-shah-ibm
Copy link
Collaborator

LGTM

Copy link
Collaborator

@diemilio diemilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since @diemilio approved, I will go ahead and merge the code.

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit 27d8542 into qiskit-community:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants