Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same changes made to original branch except no manual documentation g… #919

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

cdelnano
Copy link
Collaborator

@cdelnano cdelnano commented Feb 8, 2023

…eneration

What are the issues this pull addresses (issue numbers / links)?

#901

Did you add tests to cover your changes (yes/no)?

Yes

Did you update the documentation accordingly (yes/no)?

No

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Original branch had many files changed and I suspect it was from manual documentation generation

Details and comments

@cdelnano cdelnano marked this pull request as ready for review February 10, 2023 19:13
@cdelnano cdelnano requested review from obrienpja and removed request for priti-ashvin-shah-ibm February 10, 2023 19:13
@cdelnano cdelnano marked this pull request as draft February 10, 2023 19:17
Copy link
Collaborator

@obrienpja obrienpja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@cdelnano cdelnano marked this pull request as ready for review February 14, 2023 18:38
@obrienpja obrienpja merged commit dd95a13 into main Feb 14, 2023
@priti-ashvin-shah-ibm
Copy link
Collaborator

LGTM, Great job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants