Fix for QGmshRenderer adding a ground_plane physical group even when … #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it is not in the model.
ThomasGM4
approved these changes
Nov 9, 2022
priti-ashvin-shah-ibm
approved these changes
Nov 9, 2022
priti-ashvin-shah-ibm
deleted the
872-gmsh-renderer-ground_plane-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…it is not in the model.
What are the issues this pull addresses (issue numbers / links)?
Closes #872
Issue found by @diemilio and requires a minor change to fix it by adding a check for the ground plane layer if the
layers_dictis empty or not.Did you add tests to cover your changes (yes/no)?
No
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
This solves the issue that was caused due to missing a condition to check if the layers having ground plane actually exist in the model or not.
Details and comments
Branch can be deleted after merging.