Nick iswap #864
Merged
Nick iswap #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalanzil
added
the
documentation & tutorials
image files for new components
corrected file name for images
priti-ashvin-shah-ibm
requested changes
Nov 16, 2022
priti-ashvin-shah-ibm
approved these changes
Nov 29, 2022
ThomasGM4
reviewed
Dec 5, 2022
There was a problem hiding this comment.
I think it looks good.
Might be some conflicts with the Gmsh render (polygons overlapping), and junctions between curved poly have some issues atm (as either end up having overlapping impedance sheets with Metals, or lack of galvanic contacts).
Did you find an EPR analysis worked ok with transmon_concentric_type_2?
I would say it can get merged and then tested, or if want to test it quick first (either is good)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
This PR adds three new components and a demo notebook for full chip design which calls on each of the three components.
Did you add tests to cover your changes (yes/no)?
Yes
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
Yes
Summary
Three new components: concentric qubit, lumped resonator, tunable coupler
New demo notebook: Full physical design of three different iSWAP gates from the literature
Details and comments