Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for including mesh size fields in .geo_unrolled file and SetFactory() #858

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

AbeerVaishnav13
Copy link
Collaborator

What are the issues this pull addresses (issue numbers / links)?

Closes #857

Did you add tests to cover your changes (yes/no)?

Did external testing

Did you update the documentation accordingly (yes/no)?

No

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

Added some code to fix the exported .geo_unrolled file from Gmsh renderer to not have mesh size fields and also set the factory method to "OpenCASCADE" in the file manually.

Details and comments

N/A

Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abeer - Great that you are able to find time. Thank you for your support. LGTM.

Copy link
Collaborator

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priti-ashvin-shah-ibm priti-ashvin-shah-ibm merged commit db66978 into main Sep 26, 2022
@AbeerVaishnav13 AbeerVaishnav13 deleted the 857-fix-geo_unrolled-export branch September 26, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the .geo_unrolled file to include a warning and add 'SetFactory' method
3 participants