832 box plus buffer vs chips for Multiplanar design. #833
Conversation
…hip size, along with some error checking.
priti-ashvin-shah-ibm
requested review from
obrienpja,
AbeerVaishnav13 and
ThomasGM4
and removed request for
AbeerVaishnav13 and
obrienpja
| box_minx, box_miny, box_maxx, box_maxy = box_for_xy_bounds | ||
| safe_xy_box = list() | ||
| # Keep the order of appends in this way. It should match (minx, miny, maxx, maxy) | ||
| if box_minx < chip_minx: |
There was a problem hiding this comment.
A perhaps cleaner shorthand;
safe_xy_box = [chip_bounds_xy[n] if np.absolute(box_for_xy_bounds[n])>np.absolute(chip_bounds_xy[n]) else box_for_xy_bounds[n] for n in range(len(box_for_xy_bounds))]
Tested it but probably should double check it gives the desired output
There was a problem hiding this comment.
I agree cleaner shorthand would be nice.
There is an example in image below. The below scenario would use chip box for min_x position, when the min_x of box_for_xy_bounds would be valid
.
There was a problem hiding this comment.
Putting more logic into a single list comprehension becomes harder to debug and maintain code. I request, to go ahead with the pull request as it is.
There was a problem hiding this comment.
I can change the format of code to make more compact and readable.
|
close #832 |
What are the issues this pull addresses (issue numbers / links)?
Closes issue #832
Did you add tests to cover your changes (yes/no)?
Did you update the documentation accordingly (yes/no)?
Did you read the CONTRIBUTING document (yes/no)?
Summary
This is for Multiplanar Design with use of the layer_stack_handler.
Details and comments