This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
Vibrational structure calculations #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hc don't support it.
…netic terms. Removed the omega dependance since it's already taken care of by the parser. added the number of modals as a argument such that it can be modulated by the user.
…lt/qiskit-aqua into bosonic_operator
…lt/qiskit-aqua into bosonic_operator
Cryoris
reviewed
Sep 19, 2020
Comment on lines
110
to
111
| circuit.u1(-parameters[count] / 4 + np.pi / 4, q[i]) | ||
| circuit.u1(-parameters[count] / 4 - np.pi / 4, q[r]) |
There was a problem hiding this comment.
The U1 gate is being deprecated you should use p (for phase-gate) instead, see also Qiskit/qiskit#5083.
Suggested change
| circuit.u1(-parameters[count] / 4 + np.pi / 4, q[i]) | |
| circuit.u1(-parameters[count] / 4 - np.pi / 4, q[r]) | |
| circuit.p(-parameters[count] / 4 + np.pi / 4, q[i]) | |
| circuit.p(-parameters[count] / 4 - np.pi / 4, q[r]) |
(Also in the other places in the code 🙂)
pbark
previously approved these changes
Sep 23, 2020
|
can we add a release note and work out the changes on this so that we can merge it ? |
|
In CHC and UVCC, since num_qubits now defaults to None, can we check in construct _circuit that if the value is None and raise and error (like is done for parameter len check) with a message that num_qubits was not set. This way its a bit more obvious to an end user when they have not done things correctly rather than having to figure things out based on some exception later when it tries to use num qubits when its None. Update: I added tests to check. |
woodsp-ibm
previously approved these changes
Sep 25, 2020
woodsp-ibm
previously approved these changes
Sep 25, 2020
woodsp-ibm
approved these changes
Sep 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #1231
Details and comments
Implementation of methods for vibrational structure calculations