-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Generator #610
base: master
Are you sure you want to change the base?
Code Generator #610
Conversation
# Conflicts: # src/main/java/com/qiniu/storage/Api.java
# Conflicts: # src/main/java/com/qiniu/storage/Api.java # src/test/java/test/com/qiniu/processing/PfopTest.java
# Conflicts: # CHANGELOG.md
[Git-flow] Hi @YangSen-qn, There are some suggestions for your information: Rebase suggestions
Which seems insignificant, recommend to use For other If you have any questions about this comment, feel free to raise an issue here: |
d888050
to
e0eff9e
Compare
@@ -1,37 +1,46 @@ | |||
# Changelog | |||
|
|||
## 7.16.0(2024-09-12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YangSen-qn 这里的括号左边是全角右边是半角的,修复下吧。
@@ -1,15 +1,17 @@ | |||
##七牛设置notifyURL没有收到回调 | |||
|
|||
在使用七牛进行数据处理时用户可以使用<persistentId>来主动查询持久化处理的执行状态,具体查询方法是发送一个Get请求:http://api.qiniu.com/status/get/prefop?id= | |||
在使用七牛进行数据处理时用户可以使用<persistentId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YangSen-qn 这里为什么会换行?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用 markdown 插件进行了格式化
@@ -20,7 +22,9 @@ eg:curl -vX POST "URL" -d "name=123.jpg" | |||
url.Values{"notifyURL":[]string{""}, "force":[]string{""} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YangSen-qn 这里缺了右花括号
@@ -400,6 +500,10 @@ protected Request(String urlPrefix) { | |||
} | |||
|
|||
try { | |||
if (!urlPrefix.startsWith("http")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YangSen-qn 这里需要再严谨一点 urlPrefix.contains("://")
,否则一旦那个域名里是以 http
开头的,比如 httpcompany.com
,那么原来的逻辑就会出现问题。
@YangSen-qn: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test qiniu-java-sdk8-presubmit-integration-test |
KODO-21122
KODO-21008
KODO-20934
KODO-20799
KODO-20327