Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Generator #610

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Code Generator #610

wants to merge 24 commits into from

Conversation

YangSen-qn
Copy link
Contributor

@YangSen-qn YangSen-qn commented Oct 11, 2024

KODO-21122
KODO-21008
KODO-20934
KODO-20799
KODO-20327

@qiniu-prow qiniu-prow bot added the size/XXL label Oct 11, 2024
Copy link

qiniu-x bot commented Oct 11, 2024

[Git-flow] Hi @YangSen-qn, There are some suggestions for your information:


Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'master' of YangSen-qn:qiniu/java-sdk into code-gen

    Merge branch 'master' into code-gen

  • Following commits have duplicated messages

    format

    format

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@YangSen-qn YangSen-qn force-pushed the code-gen branch 6 times, most recently from d888050 to e0eff9e Compare October 11, 2024 07:55
@@ -1,37 +1,46 @@
# Changelog

## 7.16.0(2024-09-12)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YangSen-qn 这里的括号左边是全角右边是半角的,修复下吧。

@@ -1,15 +1,17 @@
##七牛设置notifyURL没有收到回调

在使用七牛进行数据处理时用户可以使用<persistentId>来主动查询持久化处理的执行状态,具体查询方法是发送一个Get请求:http://api.qiniu.com/status/get/prefop?id=
在使用七牛进行数据处理时用户可以使用<persistentId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YangSen-qn 这里为什么会换行?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 markdown 插件进行了格式化

@@ -20,7 +22,9 @@ eg:curl -vX POST "URL" -d "name=123.jpg"
url.Values{"notifyURL":[]string{""}, "force":[]string{""}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YangSen-qn 这里缺了右花括号

@@ -400,6 +500,10 @@ protected Request(String urlPrefix) {
}

try {
if (!urlPrefix.startsWith("http")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YangSen-qn 这里需要再严谨一点 urlPrefix.contains("://"),否则一旦那个域名里是以 http 开头的,比如 httpcompany.com,那么原来的逻辑就会出现问题。

Copy link

qiniu-prow bot commented Oct 12, 2024

@YangSen-qn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
qiniu-java-sdk11-presubmit-integration-test 4487c05 link true /test qiniu-java-sdk11-presubmit-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@YangSen-qn
Copy link
Contributor Author

/test qiniu-java-sdk8-presubmit-integration-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants