Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssl): Add API interfaces for managing SSL certificates #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(ssl): Add API interfaces for managing SSL certificates #139

wants to merge 1 commit into from

Conversation

eust-w
Copy link

@eust-w eust-w commented Aug 8, 2024

  • Add CertListReq and CertListResp for retrieving SSL certificate lists
  • Add CertDetailResp and RealCertDetailResp for retrieving SSL certificate details
  • Implement GetCertList and GetCertDetail methods for fetching SSL certificate lists and details
  • Add UploadCertReq and UploadCertResp for uploading SSL certificates
  • Implement UploadCert method for uploading SSL certificates
  • Implement DeleteCert method for deleting SSL certificates

Refs #136

@eust-w
feat(ssl): Add API interfaces for managing SSL certificates
e9c13db 
- Add CertListReq and CertListResp for retrieving SSL certificate lists
- Add CertDetailResp and RealCertDetailResp for retrieving SSL certificate details
- Implement GetCertList and GetCertDetail methods for fetching SSL certificate lists and details
- Add UploadCertReq and UploadCertResp for uploading SSL certificates
- Implement UploadCert method for uploading SSL certificates
- Implement DeleteCert method for deleting SSL certificates

Refs qiniu#136
@qiniu-prow qiniu-prow
Copy link

qiniu-prow bot commented Aug 8, 2024

Hi @eust-w. Thanks for your PR.

I'm waiting for a qiniu member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eust-w
Copy link
Author

eust-w commented Aug 8, 2024

PTAL @bachue

@eust-w
Copy link
Author

eust-w commented Aug 8, 2024

I didn't add tests with mocks because I didn't see any. If you have any good suggestions, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eust-w