Fix 'Move selected to top' breaks attribute table sorting #58901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute table dialog breaks the current sort column and sort order due to the column and order being hard-coded to 0 and Qt::AscendingOrder respectively.
agiudiceandrea
added
Bug
nyalldawson
added
backport queued_ltr_backports
|
Good catch! Looking through the git history, it seemed a bunch of cleanups have happened to this function over time which resulted in the current bug. Would you be able to extend the tests in TestQgsAttributeTable::testSelectedOnTop() to cover this fix too? |
|
No worries @nyalldawson, can do. I will have a look after work. |
|
Tests added. I think this is enough to adequately test the bug fix, but it's been a long day so hopefully I haven't made any blunders in checking the feature orders! |
nyalldawson
approved these changes
Sep 30, 2024
|
Great work, thanks @benwirf ! |
|
Thanks @nyalldawson! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently I noticed that toggling the 'Move selected to top' action in the attribute table dialog, breaks any existing sort column and sort order; the sorting is always reset to ascending on the first column.
Looking at the code, it seems that the sort column and order was hard-coded to 0 and
Qt::AscendingOrderrespectively. The existing sort column and order is retrieved but not used:Unless I'm missing something, shouldn't we be passing the
columnandordervalues to thesort()call?Screencast before:
Screencast after proposed fix: