Mesh selection actions #58888
Open
Mesh selection actions #58888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uclaros
added
Frozen
uclaros
reviewed
Sep 27, 2024
Comment on lines
287
to
292
| QList<int> verticesIndexes; | ||
| verticesIndexes.reserve( mCurrentLayer->meshVertexCount() ); | ||
| for ( int i = 0; i < mCurrentLayer->meshVertexCount(); i++ ) | ||
| { | ||
| verticesIndexes.append( i ); | ||
| } |
There was a problem hiding this comment.
meshVertexCount() says:
\note during mesh editing, some vertices can be void and are not included in this returned value
does that affect us?
Would it be better to maybe use mCurrentLayer->selectVerticesByExpression( true ) to get the indexes instead?
There was a problem hiding this comment.
Seems like a good point.
We could avoid evaluating the expression by using mCurrentLayer->nativeMesh()->vertexCount(). That would skip need to use QgsExpression and its evaluation. It is what the mCurrentLayer->selectVerticesByExpression() does internally anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two new actions for selecting vertices on Mesh: