Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info about usable "expression dialect" to filter dialog #58730

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Add info about usable "expression dialect" to filter dialog #58730

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
304848b
Show SQL dialect used for layer filtering
Sep 18, 2024
2d44364
Fix style
Sep 18, 2024
8bc8f8e
Update src/gui/qgsquerybuilder.cpp
nyalldawson Sep 29, 2024
cab1fe6
Update src/gui/qgsquerybuilder.cpp
nyalldawson Sep 29, 2024
2fb714f
Update src/gui/qgsquerybuilder.cpp
nyalldawson Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/gui/qgsquerybuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,34 @@ QgsQueryBuilder::QgsQueryBuilder( QgsVectorLayer *layer,
connect( layer, &QgsVectorLayer::subsetStringChanged, this, &QgsQueryBuilder::layerSubsetStringChanged );
layerSubsetStringChanged();

lblDataUri->setText( tr( "Set provider filter on %1" ).arg( layer->name() ) );
QString subsetStringDialect;
QString subsetStringHelpUrl;

if ( QgsDataProvider *provider = layer->dataProvider() )
{
lblDataUri->setText( tr( "Set provider filter on %1 (provider: %2)" ).arg( layer->name(), provider()>name() ) );
nyalldawson marked this conversation as resolved.
Show resolved Hide resolved
subsetStringDialect = provider->subsetStringDialect();
subsetStringHelpUrl = provider->subsetStringHelpUrl();
}
else
{
lblDataUri->setText( tr( "Set provider filter on %1 (provider: %2)" ).arg( layer->name(), layer->providerType() ) );
}

if ( !subsetStringDialect.isEmpty() && !subsetStringHelpUrl.isEmpty() )
{
lblProviderFilterInfo->setOpenExternalLinks( true );
lblProviderFilterInfo->setText( tr( "Enter a <a href=\"%1\">%2</a> to filter the layer" ).arg( subsetStringHelpUrl ).arg( subsetStringDialect ) ) ;
}
else if ( !subsetStringDialect.isEmpty() )
{
lblProviderFilterInfo->setText( tr( "Enter a %1 to filter the layer" ).arg( subsetStringDialect ) ) ;
}
else
{
lblProviderFilterInfo->hide();
}

mTxtSql->setText( mOrigSubsetString );

mFilterLineEdit->setShowSearchIcon( true );
Expand Down
9 changes: 8 additions & 1 deletion src/ui/qgsquerybuilderbase.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,16 @@ p, li { white-space: pre-wrap; }
<property name="bottomMargin">
<number>11</number>
</property>
<item row="0" column="0">
<item row="1" column="0">
<widget class="QgsCodeEditorSQL" name="mTxtSql" native="true"/>
</item>
<item row="0" column="0">
<widget class="QLabel" name="lblProviderFilterInfo">
<property name="text">
<string>Provider expression dialect</string>
</property>
</widget>
</item>
</layout>
</widget>
</item>
Expand Down
Loading