Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QgsVectorFileWriter map NaN to -DBL_MAX exporting to Shape #50507

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

domi4484
Copy link
Contributor

@domi4484 domi4484 commented Oct 11, 2022

Shape format does not support NaN for Z or M. This pr want to map NaN to -DBL_MAX when creating the WKB to pass to OGR.
A new WkbFlag value FlagExportNanAsDoubleMin was introduced to control that behaviour on WKB conversion.
This aims to fix only the "Save layer as" function. The provider was not touched.

See also discussion on #47034

@github-actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 12, 2022
@domi4484
Copy link
Contributor Author

@rouault I addressed the open points, could you redo a review please?

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Nov 15, 2022
@rouault
Copy link
Contributor

rouault commented Nov 15, 2022

I've approved the changes

@domi4484
Copy link
Contributor Author

@rouault thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants