Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression when adding feature without geom #46687 #47840

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Mar 17, 2022

On master, it wasn't possible to add new feature on a geometry less table, from the toolbar.

@3nids It seems a regression from your PR #46687

@github-actions github-actions bot added this to the 3.26.0 milestone Mar 17, 2022
@Gustry Gustry force-pushed the add_new_feature_without_geom branch from ff87afd to 2a7cb4f Compare March 17, 2022 11:29
@Gustry Gustry requested a review from 3nids March 18, 2022 09:06
@Gustry Gustry added Editing Regression Something which used to work, but doesn't anymore Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Mar 18, 2022
@github-actions
Copy link

github-actions bot commented Apr 2, 2022

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 2, 2022
@Gustry
Copy link
Contributor Author

Gustry commented Apr 4, 2022

It's not stale, waiting for a review.
Still the error on master
ksnip_20220404-100408

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Apr 4, 2022
@lbartoletti
Copy link
Member

@Gustry seems ok to me. Maybe, it's worth a test?

@3nids 3nids merged commit 2282a05 into qgis:master Apr 4, 2022
@3nids
Copy link
Member

3nids commented Apr 4, 2022

sorry for the delay!

@Gustry Gustry deleted the add_new_feature_without_geom branch April 4, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Editing Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants