Set all symbol ui to use form layout rather then custom grid layout for each symbol widget. #38
Conversation
…or each one. More consistent ui.
| @@ -26,7 +26,7 @@ | |||
| <item> | |||
| <widget class="QPushButton" name="pbnLoadDefaultStyle"> | |||
| <property name="text"> | |||
| <string>Restore Default Style</string> | |||
| <string>Restore Default Properties</string> | |||
There was a problem hiding this comment.
I made this change as Save,Load and Default Style is misleading. Clicking these buttons saves other properties of the layer not just the style.
There was a problem hiding this comment.
I agree that "properties" suits a better than "style" here.
Then raster properties dialog should be altered too, right?
There was a problem hiding this comment.
Indeed it should. I'll make the change and commit it to the pull request.
There was a problem hiding this comment.
One more thing worth considering is that the load / save / restore default / save default buttons could be integrated into one button with dropdown menu within the dialog button box (ok, apply, cancel). Those buttons are not that frequently used and squeezing them in this way may give us more vertical space for contents of the tabs.
|
Regarding symbol uis: generally I like the approach with the forms. Simple marker and svg marker you set AllNonFixedFieldsGrow flag, but the rest of the forms do not grow the fields (at least in my style). When growing the fields are IMHO way too inflated (given that the dialog can be quite wide). On the other side when not growing many times each field has a bit different size and that results into weird looking forms. It would be good to find a nice solution for the issues. Ideally the similarly wide fields should have the same size, but should not be grown until the edge. There are also some widgets which cause further visual disruptions when used with form layout: e.g. marker line - first option "with interval" is aligned to the right, other options are aligned to left. Simple line has very long line for custom dash compared to others. Could you try to address these issues somehow? Or further comment with your opinions :) |
|
No worries, I'll see what I can do. Still learning how to use the designer and how layouts in Qt behave and related to each other. |
|
How does something like this look. This set for FieldsStayAtSizeHint but I have tweaked the spinboxes so they are all the same size. I do think that looks better then what I did originally. |
|
It looks much better! |
|
Ok I'll go though and do them like this. Not sure what I was thinking when On Fri, Aug 19, 2011 at 3:33 PM, wonder-sk <
|
|
Going to close this as a redesign of this area is going to get done soon. |
Each ui widget for symbols,lines and regions used different grid layouts, spacing and over all layout was inconsistent between each one. Changed all ui widgets to use form layouts rather then grids with spacers for a more uniform layout between each widget.
Also changed Save,Load and Default Style to Save, Load and Default Properties as it was misleading before when it saved more then just the style.