Allow usage of environment variables in rules path #608
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…True) based on list of prefixes (default QDT_*, QGIS_*)
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #608 +/- ##
==========================================
- Coverage 70.63% 70.47% -0.16%
==========================================
Files 47 47
Lines 3204 3214 +10
Branches 566 567 +1
==========================================
+ Hits 2263 2265 +2
- Misses 740 746 +6
- Partials 201 203 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Guts
requested changes
Jan 24, 2025
| @@ -14,6 +14,7 @@ | |||
| # Standard library | |||
| import json | |||
| import logging | |||
| import os | |||
There was a problem hiding this comment.
Prefer complete function import rather than package. See other projects modules where we work with env vars to make it consistent with.
| only_prefixed_variables: bool = True, | ||
| variables_prefix: list[str] = ["QDT_", "QGIS_"], | ||
| ) -> None: | ||
| self.only_prefixed_variables = only_prefixed_variables |
| Returns: | ||
| dict: dict with environment variables to use in rules. | ||
| """ | ||
| env_vars = dict(os.environ) |
There was a problem hiding this comment.
It's already a mapping object no?
|
Hi @nicogodet, We're pretty interested in your feature. @jmkerloch do you want to have a look? |
|
I would really like to have control over this settings in scenario.yml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion with @Guts on IRC, this PR intends to allow usage of environment variables in rules path.
profile.json
{ [...], "rules": [ { "name": "MY_ENV_VAR exists", "description": "Deploy only if $env:MY_ENV_VAR exists", "conditions": { "all": [ { "path": "$.env.MY_ENV_VAR", "operator": "not_equal", "value": "" } ] } } ] }QdtRulesContext is modified :
_context_envto return environment variables as dictonly_prefixed_variablesboolean to control behavior of_context_envif it should return all variables or only filtered based on prefixes (default to True)variables_prefixa list with allowed prefixesTODO:
Control
only_prefixed_variablesandvariables_prefixwith 2 environment variablesQDT_RULES_ONLY_PREFIXED_VARIABLESandQDT_RULES_VARIABLES_PREFIXES--> Easy and can be implemented in generic job classControl
only_prefixed_variablesandvariables_prefixin scenario.yml --> not trivial to me as other jobs need QdtRulesContext and default QdtRulesContext initialized in generic job will not contains alteredonly_prefixed_variablesandvariables_prefixTests
Documentation