Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/202106 fetch after trash #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented May 31, 2021

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #393 (85b9acd) into master (dc7fab2) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   90.67%   90.65%   -0.03%     
==========================================
  Files         424      424              
  Lines       13668    13672       +4     
  Branches     2404     2405       +1     
==========================================
  Hits        12394    12394              
- Misses        744      747       +3     
- Partials      530      531       +1     
Flag Coverage Δ
all 90.65% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rganisms/modal-force-delete/modal-force-delete.tsx 75.75% <0.00%> (-10.45%) ⬇️
starsky/starsky/clientapp/src/hooks/use-fetch.ts 95.23% <ø> (ø)
...tarsky/starsky/clientapp/src/hooks/use-filelist.ts 86.27% <ø> (ø)
...rsky/starsky/clientapp/src/hooks/use-searchlist.ts 90.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d121d...85b9acd. Read the comment docs.

@qdraw qdraw added this to the Release 0.5.x (after 0) milestone Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant