Feature/202402 open native

[qdraw]

PR Details

Description / Motivation and Context

-toggle first time does not update due rerender

• add UI for max amount
• add UI for selecting default app

Remote starsky:

• hide application settings if local
• Add if check in menu item
• Write in docs why - no menu item when remote

Test key press feature toggle disabled
Show notification no slection CMD e
Remote only default editing no overwrite

Breaking change UseLocalDesktopUi -> UseLocalDesktop

Done:

• Check if collections false open xmp
• Collections on duplicate item
• Add check max 5 backend
• Test if run as Windows / Systemd service
• • 204 - no content - error change status code > 206
• • test readonly

il: Microsoft.AspNetCore.Server.Kestrel[13]
      Connection id "0HN1IPHEUEDDD", Request id "0HN1IPHEUEDDD:00000001": An unhandled exception was thrown by the application.
      System.InvalidOperationException: Writing to the response body is invalid for responses with status code 204.
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.FirstWriteAsyncInternal(ReadOnlyMemory`1 data, CancellationToken cancellationToken)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.WritePipeAsync(ReadOnlyMemory`1 data, CancellationToken cancellationToken)
         at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpResponseStream.WriteAsync(ReadOnlyMemory`1 source, CancellationToken cancellationToken)
         at System.IO.Compression.DeflateStream.WriteDeflaterOutputAsync(CancellationToken cancellationToken)
         at System.IO.Compression.DeflateStream.<WriteAsyncMemory>g__Core|66_0(ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
         at Microsoft.AspNetCore.ResponseCompression.ResponseCompressionBody.WriteAsync(ReadOnlyMemory`1 buffer, CancellationToken cancellationToken)
         at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.SerializeAsync(Stream utf8Json, T rootValue, CancellationToken cancellationToken, Object rootValueBoxed)
         at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.SerializeAsync(Stream utf8Json, T rootValue, CancellationToken cancellationToken, Object rootValueBoxed)
         at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.SerializeAsync(Stream utf8Json, T rootValue, CancellationToken cancellationToken, Object rootValueBoxed)
         at Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(ActionContext context, JsonResult result)
         at Microsoft.AspNetCore.Mvc.Infrastruc

Do you really want to edit all of the selected photos?

Related Issue

How Has This Been Tested

• C# Unit tests
• Typescript Unit tests
• Other Unit tests
• Manual tests
• Automatic End2end tests (starsky-tools/end2end)

Types of changes

• Added for new features
• Breaking change fix or feature that would cause existing functionality to change
• Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
• Deprecated for soon-to-be removed features
• Removed for now removed features
• Fixed for any bug fixes
• Security in case of vulnerabilities

Checklist

• My code follows the code style of this project.
• I have updated the documentation accordingly (update when needed)
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the ./history.md document

[codecov]

Codecov Report

Attention: Patch coverage is 95.21008% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 95.05%. Comparing base (1eb3deb) to head (e37f91d).
Report is 27 commits behind head on master.

Files	Patch %	Lines
...tive/OpenApplicationNative/Helpers/MacOsOpenUrl.cs	59.45%	15 Missing ⚠️
...ation.platform/Helpers/AppSettingsCompareHelper.cs	92.24%	0 Missing and 9 partials ⚠️
...cationNative/Helpers/WindowsSetFileAssociations.cs	71.42%	6 Missing and 2 partials ⚠️
...nApplicationNative/OpenApplicationNativeService.cs	88.57%	1 Missing and 3 partials ⚠️
...tion/menu-option-desktop-editor-open-selection.tsx	93.93%	4 Missing ⚠️
...ApplicationNative/Helpers/WindowsOpenDesktopApp.cs	94.44%	2 Missing ⚠️
...dation.platform/JsonConverter/EnumListConverter.cs	88.23%	1 Missing and 1 partial ⚠️
...dal-desktop-editor-open-selection-confirmation.tsx	95.83%	0 Missing and 2 partials ⚠️
...folder/preferences-app-settings-storage-folder.tsx	95.55%	0 Missing and 2 partials ⚠️
...arsky.feature.trash/Services/MoveToTrashService.cs	87.50%	0 Missing and 1 partial ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
- Coverage   95.32%   95.05%   -0.28%     
==========================================
  Files         586      607      +21     
  Lines       22364    22478     +114     
  Branches     4088     3648     -440     
==========================================
+ Hits        21319    21366      +47     
+ Misses        655      625      -30     
- Partials      390      487      +97     

Flag	Coverage Δ
all	95.05% <95.21%> (-0.28%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.4% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarCloud