Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Update internal torch.norm calls to torch.linalg.norm #203

Closed
KarahanS opened this issue Apr 1, 2023 · 2 comments
Closed

Improvement: Update internal torch.norm calls to torch.linalg.norm #203

KarahanS opened this issue Apr 1, 2023 · 2 comments

Comments

@KarahanS
Copy link
Contributor

KarahanS commented Apr 1, 2023 •
edited
Loading

In various places, we are using torch.norm to calculate the vector norms of the inputs (for example here) . According to the documentation:

torch.norm is deprecated and may be removed in a future PyTorch release. Its documentation and behavior may be incorrect, and it is no longer actively maintained.

It's better to switch to alternatives such as torch.linalg.norm or torch.nn.function.normalize if applicable.
@KarahanS
Copy link
Contributor Author

KarahanS commented Apr 1, 2023

I'll be working on this after the PR #202 is merged/closed.

@helios2003
Copy link

Hello this is Ankit ....and I like to contribute open source. I found this particular issue interesting. Can I be assigned this issue?

@helios2003 helios2003 mentioned this issue Apr 1, 2023
Closed
@monatis monatis mentioned this issue Apr 3, 2023
Merged
@KarahanS KarahanS mentioned this issue Apr 4, 2023
Merged
monatis pushed a commit that referenced this issue Apr 4, 2023
@KarahanS
switch from torch.norm to torch.nn.functional.normalize #203 (#206)
2371ddf
@KarahanS KarahanS closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KarahanS @helios2003