fix(privateinternetaccess): fix getting token for port forwarding #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
previously approved these changes
Sep 4, 2022
Hi @qdm12 , no problem! You beat me to the punch here, thanks for fixing it up. Once again, thanks for creating and maintaining gluetun! |
|
Awesome thanks! Asking this since I'm recording myself doing gluetun development (setup environment, add a vpn provider). Thanks again for the fix, I'll do a release soon-ish. |
CMarcJoubert
pushed a commit
to FideresDev/gluetun
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection to PIA using OpenVPN worked fine, but getting a token for the port forwarding service resulted in HTTP errors.
Looking at the latest official shell script to get a token it seems that the token URL and method have changed. This PR adjusts gluetun to match.
Note: this is my first time writing/using Go.