Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question sometimes reveals answer when skips are enabled #295

Closed
justinkeung1018 opened this issue Jun 13, 2024 · 2 comments
Closed

Question sometimes reveals answer when skips are enabled #295

justinkeung1018 opened this issue Jun 13, 2024 · 2 comments

Comments

@justinkeung1018
Copy link

image
As seen in the screenshot, the answer and the whole question reveal themselves while it is supposed to still be reading "... bitten in the eye in the process of...". This happens sporadically when skips are enabled.

@BolunThompson
Copy link
Contributor

BolunThompson commented Jun 30, 2024

With thanks to a member of my QB team, here's a more detailed description of the issue:

There's a timer on the side that starts counting down whenever you buzz in for a question. Once the timer runs out, it reveals whatever question you're on.
If you answer & skip before the timer runs out, then instead of resetting it just reveals the next question.
To avoid this you have to wait until the timer runs out before skipping to the next question.
If you wait for the timer to run out after answering, it inevitably marks your answer as wrong once it reaches 0.

On my iPhone, the timer is only open when the options are open.

before
after

@PSlape2
Copy link

PSlape2 commented Jun 30, 2024

I believe the error is that the timer on line 426 of tossups.js is not being ended when the player buzzes, so if the player moves to the next question before the timer ends, it continues running and preemptively ends the next question.

Timer:

timer.startTimer(DEAD_TIME_LIMIT, revealQuestion);

geoffrey-wu added a commit that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants