Enable customizing the save statistics time interval #21291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded statistics save interval with configurable value New entry located in Advanced section Closes qbittorrent#21285
Merge with master
|
I would put this setting near "Save resume data interval" |
thalieht
reviewed
Sep 3, 2024
Tested, works as intended. |
Relocate the new option in the menu and moved the corresponding code around
|
Moved it according to @thalieht 's suggestion[1]. Also moved the corresponding code around to keep the ordering of the items & fixed the rest of the remarks. [1]:
|
thalieht
previously approved these changes
Sep 4, 2024
Chocobo1
reviewed
Sep 6, 2024
Chocobo1
reviewed
Sep 13, 2024
Chocobo1
approved these changes
Sep 14, 2024
glassez
reviewed
Sep 14, 2024
glassez
approved these changes
Sep 14, 2024
|
@burnerelu
Nah, just wait for someone's free time to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the Advanced section of the Preferences menu with a new field, allowing changing the time statistics save interval. A null value will prevent recurrent saving.
This aims to provide the feature requested in issue #21285
Tested updating the value from the web UI and reading it from the local client and the other way around. Did not test the actual file update time, as I did not touch the mechanism below the
saveStatisticsfunction.I did not extend the lang/translation files as I wasn't sure I was supposed to. This is my first contribution to qBittorent, so I'm not familiar with the WoW
closes #21285