WebUI: Improve subcategories #21269
Merged
WebUI: Improve subcategories #21269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
reviewed
Aug 31, 2024
skomerko
force-pushed
the
webui-improve-subcategories
branch
from
8bc53d9
to
bcf5686
Compare
|
@Chocobo1, during my tests I noticed that categories are sorted differently in the WebUI (numeric collation is used):
vs GUI:
Not sure which one should be used, just letting you know. |
We just stick to the platform native natural sorting if it provides one. The occasional discrepancy between gui and webui is known and if that is what the platform provides then so be it, after all qbt just accustom to the native platform. |
skomerko
force-pushed
the
webui-improve-subcategories
branch
from
bcf5686
to
b550bde
Compare
Chocobo1
approved these changes
Sep 6, 2024
thalieht
approved these changes
Sep 6, 2024
|
@skomerko |
Chocobo1
pushed a commit
that referenced
this pull request
Oct 12, 2024
This PR adds following improvements: * Remove unused tracker entries while processing sync data * Take into account filter selection & terms when performing 'Start/stop/delete' context actions in filter lists Now, only filtered torrents will be affected by them, just like in the GUI. * Provide better feedback when performing 'Start/stop/delete' context actions in filter lists Small improvement over GUI - now these actions will be disabled if it's not possible to use them. * Add context menu to status filter list * Fix error when toggling filter title Fixup for small bug introduced in #21269 PR #21438.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves subcategories.
Now they should fully match GUI behavior, please let me know if I missed something.
Still plenty of room to improve them further (e.g styling/CSS) but for now I wanted to keep the changes to the minimum.
Also included small tweaks to category context menu actions