Dreadful look on macOS Mojave with dark theme

[pshirshov]

Please check https://bugreports.qt.io/browse/QTBUG-68850

[evansan]

I haven’t tested qt 5.11, and it doesn’t look like you are using qt 5.11. I have tested the official release(qt 5.8) and another version with qt 5.9, this problem appears on both.

[pshirshov]

It's latest qbittorrent release for mac. QT 5.8.0.

Though I doubt there would be any difference for any QT version, the framework itself is buggy and at the moment they have just a dirty workaround for 5.11 which still isn't accepted (check the qt bugtracker link above)

But it's possible to mitigate the issue by setting proper stylesheets in the app.

[ThisIsJeron]

any update on this? now that Mojave is officially out...

I think the gray is a little off, should be a little bit darker

[quicoto]

The app also seems to crash with Mojave? It wasn't happening before. Not sure if it's a coincidence.

[zdlo]

The SVG icons also render low-res on retina displays on Mojave, as well as on High Sierra (as mentioned in #9549).

[Kolcha]

so, finally Qt has dark theme support! nothing must be done
I compiled master branch as is (but in own way, without homebrew).
and have no any issues with icons, see attached screenshots
anyone can download this build here, minimum supported macOS version is 10.12.

[quicoto]

@Kolcha any idea when the new release? So we get it naturally through an update?

[zeule]

First we have to wait for the Qt 5.12 release.

[eduarcor]

so, finally Qt has dark theme support! nothing must be done
I compiled master branch as is (but in own way, without homebrew).
and have no any issues with icons, see attached screenshots
anyone can download this build here, minimum supported macOS version is 10.12.

It definitely has some bugs, but is usable. Thanks!!

[evansan]

@Kolcha Can you upload a newer build? Thanks so much.

[Kolcha]

done , compiled from latest commit 1baa71c from master branch

[eduarcor]

Someone knows when the 5.2 will be released officially? Cheers.

[yuxincs]

Someone knows when the 5.2 will be released officially? Cheers.

In case you don't know, It was released officially yesterday (12.6)

[eduarcor]

Someone knows when the 5.2 will be released officially? Cheers.

In case you don't know, It was released officially yesterday (12.6)

Not the qt 5.12, but bittorrent 4.2... (sorry for the typo)

[thalieht]

For qBittorrent alpha is just a label for the dev branch. It doesn't mean anything special and usually all versions are just the latest commit from that branch.

[eduarcor]

I am not talking about the alpha, but the final 4.2 release. Someone knows about when the 4.2 version would be release?? Even the 4.1.4 was not release on macOS...

[evansan]

Can you give an explanation why macOS doesn't get 4.1.4? @sledgehammer999

[eduarcor]

There is no place in the whole internet where you can download qbittorrent 4.1.4 for macOS... just take a look... was not released in any place... maybe there is a compiling problem or something? I don't know... but there isn't...

[Kolcha]

qBittorrent 4.1.4 release for macOS

so, I compiled 4.1.4 for macOS . anyone can download it.

Libraries used:

• Qt 5.12.0
• boost 1.68.0
• libtorrent 1.1.11
• OpenSSL 1.1.1a

This release supports macOS dark theme. minimum supported macOS version is 10.12 (inherited from Qt).

Upd.: made some workaround to place progress bars where they must be (but draw in different style).
@zdlo just re-download dmg file, link remains the same.

[eduarcor]

Thanks Kolcha, at least there is a 4.1.4 version (it definitely has some graphics glitches, I am sure for the new qt version, but is usable)... What I don't understand is why this version was not released for MacOS... Don't understand it at all.

[zdlo]

qBittorrent 4.1.4 release for macOS

Thanks, Kolcha! Is it just me who gets a progress bar on the first line of every list?

[evansan]

@Kolcha Are you considering sending a pull request for the workaround?

[Kolcha]

@evansan this workaround likely "quick and dirty hack" rather than true workaround. so it is not worth to be published as pull request, you can view patch here.

[vit9696]

@sledgehammer999 I suggest you temporarily add NSRequiresAquaSystemAppearance = NO to Info.plist file for the 4.1.x branch. This will avoid the disaster until a migration to a more recent Qt happens. Note: https://stackoverflow.com/a/52508548

@zdlo, the progress bar issue was mentioned in #8419. Somebody needs to investigate it and perhaps ask Qt devs to unbork their code.

[eduarcor]

@evansan this workaround likely "quick and dirty hack" rather than true workaround. so it is not worth to be published as pull request, you can view patch here.

@Kolcha To be honest, your patch is working really well, and I still haven't seen any glitches, besides that it solved the "Done" menu as well, (because I couldn't see anything, until this patch!! So, it didn't change just the bar... Just take a look and compare... with both (and with some torrents working of course). Now it is a pleasure to use it!! Thanks!! And it deserves a pull... or someone to find a way to solve it at least...

[vit9696]

I am not happy with such a workaround honestly, yet I have to admit that it does not look particularly bad.

In my opinion, we could merge it, yet guarded with Qt version being 5.11 or 5.12. Ideally that is reported upstream and researched sooner or later. Keeping this silent and having workarounds could make things much worse in the future.

[Kolcha]

I created small app which reproduce mentioned bug with progress bar and reported progress bar related bug to Qt (QTBUG-72558). So, wait until Qt devs fix it.

[sledgehammer999]

The builds are late because now I have access to a high sierra machine (previously was yosemite) and I am rebuilding the toolchain (boost, libtorrent, qt, openssl) etc...

I am aiming to use Qt 5.9.7 (part of LTS series) instead of 5.8.0. Is it supposed to have the issues with progressbars?
About the dark theme: As far as I understand it, this was introduced in Mojave. And you can have support for it by using xcode 10 and the 10.14 macOS SDK and of course Qt 5.12.
Qt 5.12 has support only for mojave, high sierra and sierra. Is this enough for the macOS world? Honestly I don't have a clue if people stay behind in OS versions on macOS like they do on Windows.
I would be happy to provide 2 builds for each release. One with 5.9.7 and one with 5.12 to cover all bases, but 5.9.7 doesn't work with xcode 10/10.14 macOS SDK.
@Kolcha is it possible to have 2 versions of xcode installed and 2 versions of the SDK installed on the same machine?

[pshirshov]

Why not to build two distros - a "legacy" one with old QT and a "new" one with .12?..

[evansan]

@pshirshov read from here #9096 (comment)

[mmatviyiv]

Why not to build two distros - a "legacy" one with old QT and a "new" one with .12?..

+1

I would like to keep using an official brew'ed version. It's a really handy way for handling third-party software on MacOS. So, please add the dark-mode support to the official build, thanks

[pshirshov]

@evansan: the comment doesn't answer my question in fact. Whats preventing the team from having two "official" builds?

May people don't trust non-official binaries.

[sledgehammer999]

Whats preventing the team from having two "official" builds?

The updater mechanism, isn't build to look for different versions based on OS version.

[terrorist96]

I've built the official build using Qt 5.9.7 in order to support a wider range of macOS versions. However, the Qt 5.9.x series don't handle correctly the dark mode of Mojave. That mode is correctly handled in Qt 5.12.x series.

Here is a build using Qt 5.12.0 (I didn't have time to build Qt 5.12.3): https://builds.shiki.hu/temp/qbittorrent-4.1.6-qt5.12.dmg

Will there be an official update soon that includes this fix? Would rather wait if it's coming soon than downloading an unofficial version.

[jonathancross]

Here is a build using Qt 5.12.0 (I didn't have time to build Qt 5.12.3): https://builds.shiki.hu/temp/qbittorrent-4.1.6-qt5.12.dmg

@sledgehammer999 Can you please sign this? Thanks.

[42ae]

May people don't trust non-official binaries.

👍 I agree with you!

In the meantime, for those who don't want to have to deal with this messy UI, you can revert the app back to the light theme:

$ defaults write $(osascript -e 'id of app "qbittorrent"') NSRequiresAquaSystemAppearance -bool yes

[ozio]

I'm sorry, but why can't you just release minor version with updated qt? for me it's kind of a stupid to download the same but fixed version.

[hernangonzalez]

Still looking so ugly :/

[realish1]

Just downloaded Qt 4.1.7 and it is still ugly to the point of unusable. Does anyone know if they're even planning to fix this?

[Piccirello]

Qt 5.9 includes support for 10.10 and 10.11, while 5.12 drops support for these macOS versions.

@sledgehammer999 10.11 is unsupported by Apple as of August 2018, per Wikipedia. Would you be open to building future macOS releases with Qt 5.12? And ideally re-releasing 4.1.7 built with Qt 5.12.

[terrorist96]

I just downloaded 4.1.7 and it's fixed for me.

[sledgehammer999]

@Piccirello there's a problem with the mainsite. It hasn't yet synced the files from the git website repo, so my changes/info aren't live yet. And the admin hasn't responded to me yet.
Long story short: The new official v4.1.7 build uses Qt 5.12.2
I would use Qt 5.13 but: https://bugreports.qt.io/browse/QTBUG-77310

[Piccirello]

Confirmed this is fixed for me- v4.1.7 uses Qt 5.12.2

Not sure who the admin is but are we relying on an external party for the site? I'd be happy to provide hosting so that we're not reliant on someone else to sync our changes.

[sledgehammer999]

Thanks for the offer. The admin isn't an outsider, although I don't remember his github nick. He's also the forum admin. He has taken care of these things for a lot of years, probably from the beginning. I talked to him a few days ago, so I know he hasn't gone missing.

[eduarcor]

Hello guys, where are the version 4.1.7 to download? not in the official page... could you please guide me to a link?
Does it incorporate all the @Kolcha fixes in the UI? Curiously in v4.1.6 the QT version used by Kolcha is 5.12.3 and it works like a charm, doesn't it work for you?
Thx

[sledgehammer999]

@eduarcor Just go to Fosshub: https://www.fosshub.com/qBittorrent.html
Or if you an older version the updater should take you there.

[eduarcor]

Thanks.
Why using the 5.12.2 instead the 5.12.3 used by the 4.1.6 version? It is weird...

[Kolcha]

@eduarcor , see #9096 (comment) for info about why Qt 5.12.2 is used. my build has newer Qt because I build with c++ 14, so I didn't face build issues, but I faced other strange issue with Qt 5.13 and dev, but this is another story...
and again, I fixed almost nothing! just built qBittorrent with newer Qt which supports dark theme. Few small issues I fixed were related to progress bar, they were merged very long time ago and were included even in 4.1.6

Nice to see that this issue is closed now!

P.S.> I still building qBittorrent from master branch periodically, anyone interested can download my builds using this link

[eduarcor]

@Kolcha, And did you build the v4.1.7 itself? with the latest 5.12.4? If true, could you please share if there is not problem with it?

[Kolcha]

@eduarcor my 4.1.7 build, compiled with Qt 5.13.0, libtorrent 1.1.13 and OpenSSL 1.1.1c

[eduarcor]

@eduarcor my 4.1.7 build, compiled with Qt 5.13.0, libtorrent 1.1.13 and OpenSSL 1.1.1c

@Kolcha, nice, thanks!! Apart from the fact of changing the libraries (which I don't know if it has any advantage) and not being signed, has it any glitch or it corrects any current one, or is exactly the same as the official? (I haven't seen any difference in a brief look).

Thanks.

[Kolcha]

@eduarcor , I modified nothing (at least in code), the only one difference only the way how app was build (I make some changes in build system files and build in totally different way comparing to described in qBittorrent Wiki). so you can think that my build exactly the same as official

[eduarcor]

Good to know. Thanks!!
Not even the official one is signed as it keeps says is from an unidentified developer.

[blahdy]

If someone's interested in an even less dreadful look on macOS - you're welcomed to try my tailored version at https://github.com/blahdy/qBittorrent/releases
Read the description, btw

[ScyllaHide]

windows too? or only macos? :(