Skip to content

Commit

Permalink
konveyor#392 Use fernflower (Java decompiler) from /usr/local/bin to …
Browse files Browse the repository at this point in the history
…make it more portable

Placing it in /bin is not possible for, e.g., MacOS, and even not recommended for
arbitrary Linux systems. Therefore, it almost only works in a container which
prohibits contributors to debug locally in an efficient way.

CAUTION: This change will require a change in https://github.com/konveyor/java-analyzer-bundle/blob/9cb5a19d87531487df378afbb37de4c60d16ae87/Dockerfile#L35-L35 as well.
Signed-off-by: Gerd Aschemann <gerd@aschemann.net>
  • Loading branch information
ascheman committed Nov 10, 2023
1 parent 541a2d0 commit 9234c30
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion provider/internal/java/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func decompile(ctx context.Context, log logr.Logger, filter decompileFilter, wor
continue
}
cmd := exec.CommandContext(
ctx, "java", "-jar", "/bin/fernflower.jar", job.inputPath, outputPathDir)
ctx, "java", "-jar", "/usr/local/bin/fernflower.jar", job.inputPath, outputPathDir)
err := cmd.Run()
if err != nil {
log.V(5).Error(err, "failed to decompile file", "file", job.inputPath)
Expand Down

0 comments on commit 9234c30

Please sign in to comment.