-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update susceptibility figure with a different brain dataset #19
Conversation
On it |
This came up in another context - I recall having a figure rendering issue with trying to push unbuilt notebooks - let me give it another shot to see if that was the case.. If it is the case, we can minimize the issue by ensuring only changing them through squashed PRs, and also when we "publish" or release the book we could rebase to that commit. But, I agree, the ideal situation would be to avoid pushing the built ones altogether |
I imagine you either reused your old notebook (from your repo or local, not the mooc) or edited it? It appears to be too small and stretched, I likely edited the notebook while preparing the website to make it "prettier", or maybe changes were inadvertantly made on your end or on purpose to move the drop down box. Let me know if you suspect why it doesn't look as the current website does: Nonetheless, I'll try to make it match closer to the older website version, maybe with the dropdown moved. |
@po09i How about this? |
I removed the title - it was being change to "Brain/cylinder" after using the dropdown anyways. And now this gives us plenty of space to see the dropdown values without sacrificing horizontal space for the button |
Here's the output of the site when pushing unbuilt notebooks for your notebook, Now that I'm remembering, I possibly turned off a "build notebooks" to avoid some issues, either during dev or to prevent changes in dependencies in breaking the images. I'll revisit this, but for your PR I think we should just push the built notebook as all the other notebooks are curently being hosted as built |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll merge and you can verify if it looks good on the live site
@po09i have a look on the live site and let me know if any other changes are needed - https://qmrlab.org/mooc/magnetic-susceptibility |
Looks great! Thanks! |
The brain dataset used for the susceptibility figure was changed and the relevant modifications were done in the notebook and the text.
Note:
Should we really push notebooks fully built? Every modifications adds a lot of data to the git history...
The modified source data is here. It needs to be added to the mooc-data repo
brain.zip