Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]rtmp pull增加ack应答提高兼容性 #154

Merged
merged 3 commits into from
Apr 29, 2022
Merged

[feat]rtmp pull增加ack应答提高兼容性 #154

merged 3 commits into from
Apr 29, 2022

Conversation

joestarzxh
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #154 (6107a5e) into master (d2b80a4) will decrease coverage by 0.26%.
The diff coverage is 52.00%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   60.03%   59.76%   -0.27%     
==========================================
  Files         114      114              
  Lines        9000     9022      +22     
==========================================
- Hits         5403     5392      -11     
- Misses       3004     3043      +39     
+ Partials      593      587       -6     
Impacted Files Coverage Δ
pkg/rtmp/message_packer.go 79.60% <0.00%> (-1.62%) ⬇️
pkg/rtmp/client_session.go 55.17% <60.00%> (-0.12%) ⬇️
pkg/rtmp/client_pull_session.go 54.28% <100.00%> (+1.34%) ⬆️
pkg/logic/group.go 39.64% <0.00%> (-6.17%) ⬇️
pkg/httpflv/server_sub_session.go 88.88% <0.00%> (-3.71%) ⬇️
pkg/logic/group__relay_pull.go 26.31% <0.00%> (-1.76%) ⬇️
pkg/logic/server_manager.go 64.55% <0.00%> (-1.50%) ⬇️
pkg/logic/logic.go 0.00% <0.00%> (ø)
pkg/remux/avpacket2rtmp.go 51.39% <0.00%> (ø)
pkg/rtprtcp/rtp_unpacker_avc_hevc.go 60.84% <0.00%> (+1.20%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b80a4...6107a5e. Read the comment docs.

@@ -120,6 +123,7 @@ func NewClientSession(t ClientSessionType, modOptions ...ModClientSessionOption)
},
debugLogReadUserCtrlMsgMax: 5,
hc: hc,
peerWinAckSize: peerBandwidth,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否需要初始化为 peerBandWidth,
初始化为 peerBandWidth则默认回复ack了,
是否只由收到 RtmpTypeIdWinAckSize 才回复ack更合适?
这个做法是参考了什么开源项目吗?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看到你下面说参考srs了,最好再找一个开源实现做对比,比如nginx-rtmp-module

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

初始化可能就搞成option设置更好

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我同意放option中。
srs中,对应的是in_ack_size吗?我看它配置中的默认值是0?
所以你也放option中,并且默认值为0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,srs不做客户端它是可以配置文件配置。option提交了

@q191201771 q191201771 merged commit 120afe8 into q191201771:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants