Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion of factors in RiverSplitWithGaugeNode is incorrect #241

Open
jetuk opened this issue Aug 12, 2024 · 0 comments · May be fixed by #318
Open

Conversion of factors in RiverSplitWithGaugeNode is incorrect #241

jetuk opened this issue Aug 12, 2024 · 0 comments · May be fixed by #318
Labels
bug Something isn't working

Comments

@jetuk
Copy link
Member

jetuk commented Aug 12, 2024

The implementation TryFrom<RiverSplitWithGaugeNodeV1> for RiverSplitWithGaugeNode is not correct. The representation of the factors is the not the same between v1.x and v2.x of Pywr. v2.x requires factors as a proportion of the main flow. Whereas v1.x requires specifying the factors as ratios.

pywr-next/pywr-schema/src/nodes/river_split_with_gauge.rs

Line 220 in 745d6d0

let splits = v1

Possible solutions:

  • Return a ConversionError stating these factors cannot be converted automatically,
  • Update the node to align more closely with v1.x and allow the conversion to be made, or
  • Add interim parameters to calculate the proportion correctly.
@jetuk jetuk added the bug Something isn't working label Aug 12, 2024
jetuk added a commit that referenced this issue Dec 19, 2024
@jetuk
fix: Try to convert RiverSplitWithGauge factors correctly.
5638bb9 
Add a conversion function for the factors on RiverSplitWithGauge.
The factors have changed in this implementation and require
conversion from ratios to proportions. This is only possible
if they existing factors are all constants.

Fixes #241.
@jetuk jetuk linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Try to convert RiverSplitWithGauge factors correctly. pywr/pywr-next
1 participant
@jetuk