Skip to content

Commit

Permalink
Test: Preventively fixed potential issue with virtualenv on py34
Browse files Browse the repository at this point in the history
Details:

* On other pywbem projects, the installtest failed on Python 3.4 with latest
  package levels because virtualenv raises AttributeError (see pypa/virtualenv#1963).
  Fixed that preventively by excluding virtualenv 20.0.32.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
  • Loading branch information
andy-maier committed Oct 4, 2020
1 parent 043264a commit ad23733
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ colorama>=0.4.0; python_version >= '3.5'

# Virtualenv
# Virtualenv 20.0.19 has an issue where it does not install pip on Python 3.4.
virtualenv>=14.0.0,!=20.0.19; python_version < '3.5'
# Virtualenv 20.0.32 has an issue where it raises AttributeError on Python 3.4.
virtualenv>=14.0.0,!=20.0.19,!=20.0.32; python_version < '3.5'
virtualenv>=16.1.0; python_version >= '3.5' and python_version < '3.8'
virtualenv>=20.0.0; python_version >= '3.8'

Expand Down
3 changes: 3 additions & 0 deletions docs/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ Released: not yet
* Error in test defintion for qualdecl Indication causes failure with pywbem
i.1.0 where mocker validates qualifiers scopes. (see issue #766)

* Test: Preventive fix for potential issue with virtualenv raising
AttributeError during installtest on Python 3.4. (see issue #775)

**Enhancements:**

* Introduced caching of the mock environment used by connection definitions in
Expand Down

0 comments on commit ad23733

Please sign in to comment.