Skip to content

Commit

Permalink
Test: Fixed issue with virtualenv on py34
Browse files Browse the repository at this point in the history
Details:

* The installtest failed on Python 3.4 with latest package levels because
  virtualenv raises AttributeError (see pypa/virtualenv#1963).
  Fixed that by excluding virtualenv 20.0.32. Also, excluded virtualenv 20.0.19 to
  make sure an earlier error where pip did not install on Python 3.4.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>
  • Loading branch information
andy-maier committed Oct 4, 2020
1 parent 022e2f8 commit 039e9f6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 3 additions & 0 deletions docs/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ Released: not yet

**Bug fixes:**

* Test: Fixed issue with virtualenv raising AttributeError during installtest

This comment has been minimized.

Copy link
@gaborbernat
on Python 3.4. (see issue #61)

**Enhancements:**

**Cleanup:**
Expand Down
4 changes: 3 additions & 1 deletion test-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ pytest>=4.4.0,!=6.0.0; python_version >= '3.7'
# Install test direct dependencies:

# virtualenv
virtualenv>=14.0.0; python_version < '3.5'
# Virtualenv 20.0.19 has an issue where it does not install pip on Python 3.4.
# Virtualenv 20.0.32 has an issue where it raises AttributeError on Python 3.4.
virtualenv>=14.0.0,!=20.0.19,!=20.0.32; python_version < '3.5'
virtualenv>=16.1.0; python_version >= '3.5' and python_version < '3.8'
virtualenv>=20.0.0; python_version >= '3.8'

Expand Down

0 comments on commit 039e9f6

Please sign in to comment.