Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed python widget key precision to match JS #1054

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Conversation

philippjfr
Copy link
Member

So this is pretty strange, as revealed in #1052, it turns out the precision the widget keys are set to in Python does not match the precision specified by the widgets. It seems I changed the value as part of a fix for DynamicMap. Will have to investigate what that was about before merging this.

@philippjfr philippjfr force-pushed the widget_precision branch 2 times, most recently from 8c90edc to 34b8076 Compare January 16, 2017 17:52
@philippjfr
Copy link
Member Author

May have to rebuild tests but this is now behaving correctly.

@jlstevens
Copy link
Contributor

Happy to merge once the tests pass.

I hope we will one day be able to test this properly - maybe using selenium? :-)

@philippjfr
Copy link
Member Author

Yes, we'll definitely want to add selenium tests at some point. I'd like to add some to test bokeh stream events before releasing 1.7.

@jlstevens
Copy link
Contributor

I'd like to add some to test bokeh stream events before releasing 1.7.

That would be a very good idea. Anyway, tests have passed so I will now merge.

@jlstevens jlstevens merged commit 890d09d into master Jan 16, 2017
@philippjfr philippjfr deleted the widget_precision branch January 27, 2017 02:53
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants