Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoloMap issue in Containers tutorial #1052

Closed
jlstevens opened this issue Jan 11, 2017 · 5 comments
Closed

HoloMap issue in Containers tutorial #1052

jlstevens opened this issue Jan 11, 2017 · 5 comments
Assignees
Labels
type: bug Something isn't correct or isn't working type: docs Related to the documentation and examples

Comments

@jlstevens
Copy link
Contributor

In the Containers tutorial the frequency slider only does anything for phase=0:

image

Nothing updates if you try to use a non-zero phase. Maybe this is a floating point comparison issue?

@jlstevens jlstevens added type: bug Something isn't correct or isn't working type: docs Related to the documentation and examples labels Jan 11, 2017
@philippjfr
Copy link
Member

So this is pretty odd, the precision of the key matching is currently set to 11 decimal places while the JS code is using 10 decimal places. Not quite sure how anything has been working, but setting it to 10 in Python seems to work.

@jlstevens
Copy link
Contributor Author

Any mismatch seems problematic and I am also surprised anything worked! Is it possible to make this precision a global variable so we can make sure it stays matched between Python and JS?

@philippjfr
Copy link
Member

Turned out to be my fault, I introduced a fix in Python to fix rounding outside the defined range on a DynamicMap (remember the issues with pi), which wasn't mirrored on the JS end. Haven't worked out the correct fix yet though, as I suspect my approach to that issue was generally flawed.

@philippjfr
Copy link
Member

Fixed in the PR referenced above.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working type: docs Related to the documentation and examples
Projects
None yet
Development

No branches or pull requests

2 participants