-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DataID attribute access in seviri_l2_grib reader #2408
Remove DataID attribute access in seviri_l2_grib reader #2408
Conversation
Over-mocking in tests gets us again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is any type of urgency to this PR for your/EUM's work, I'm OK merging it into main if you can confirm that all tests pass locally. We'll deal with the NetCDF test failure in CI in another PR.
@djhoese I'm missing packages needed to run all the tests, but I can confirm that |
I just merged #2412 , so the tests should be fixed now if you merge main into this PR |
…eviri_grib_attribute_access
Codecov Report
@@ Coverage Diff @@
## main #2408 +/- ##
=======================================
Coverage 94.76% 94.76%
=======================================
Files 329 329
Lines 48878 48879 +1
=======================================
+ Hits 46318 46319 +1
Misses 2560 2560
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The recently merged PR #2396, removed the DataID attribute access and modified affected readers accordingly. However, two instances in the
seviri_l2_grib
reader were not modified leading to failure when using this reader with the current main. This PR resolves this issue.The initial commit fixed the attribute access, but broke the reader's unit test since a mocked
DataID
was used, which lead toTypeError
since the mock object was not subscriptable. This was resolved by usingmake_dataid
for the test instead.