Enhance code quality #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 89.07% 89.96% +0.89%
==========================================
Files 24 24
Lines 842 947 +105
==========================================
+ Hits 750 852 +102
- Misses 92 95 +3 ☔ View full report in Codecov by Sentry. |
pkhalaj
force-pushed
the
enhancement/more-tests-and-cleanup
branch
2 times, most recently
from
4982384 to
ec787e7
Compare
- Fix typos. - Fix broken links. - Improve readability.
Update conf.py with functionalities to specify which special members have to be kept in the documentation.
The name of the `pipelines` module was mistakenly spelled as `piplines`.
There were several places that we had used `mock data` to refer to data generated for testing purposes. This was misleading as we are actually generating the data and the API calls are not mocked. Example `mock_database` is renamed to `test_database`.
As a result, `test_utils` and the `queries` route handler have been also updated.
pkhalaj
force-pushed
the
enhancement/more-tests-and-cleanup
branch
3 times, most recently
from
03506ae to
4f426ad
Compare
pkhalaj
force-pushed
the
enhancement/more-tests-and-cleanup
branch
from
4f426ad to
76fe40e
Compare
The new version of FastAPI recommends using `Annotated` for queries. This also resolves the issue with ruff complaining about `Query(None)`.
pkhalaj
force-pushed
the
enhancement/more-tests-and-cleanup
branch
from
2c8a672 to
a4298f5
Compare
This led to the removal of some redundant type checks.
The bug had to do with multiple deletion in the recorder. The log message was added to the auto exception handler.
Add two auxiliary methods which simplify the implementation of the main method.
mraspaud
reviewed
May 30, 2024
The function is named `make_query_string`
The old name of the function was `parse_config_yaml_file`. The function now accepts a number of different types for the input arg `file`.
This logs and catches unhandled exceptions.
mraspaud
reviewed
May 31, 2024
mraspaud
reviewed
May 31, 2024
mraspaud
reviewed
May 31, 2024
mraspaud
reviewed
May 31, 2024
mraspaud
reviewed
May 31, 2024
mraspaud
reviewed
May 31, 2024
- Remove type hint for `file`. - Amend docstring. - Remove explicit exception handling for parsing and reading the file.
As a result, the signature of `run_server()` and `api_server_process_context()` have been changed. They now only accept a `config` object of type `AppConfig`.
pkhalaj
force-pushed
the
enhancement/more-tests-and-cleanup
branch
from
bf6a73d to
506f122
Compare
The dependencies are now brought after the first main dependent function that uses them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about
conf.pyto exclude unused special members.