Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny fix simplifying the rsr plot code #246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adybbroe
Copy link
Collaborator

@adybbroe adybbroe commented Dec 18, 2024

Simplify code, and remove unnecessary argument specifications and typing in the composite_rsr_plot.py script.

(This was a small improvement which was forgotten in PR #240)

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Signed-off-by: Adam.Dybbroe <a000680@c22526.ad.smhi.se>
@adybbroe adybbroe self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.28%. Comparing base (8ca1082) to head (1660fd4).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   90.25%   90.28%   +0.03%     
==========================================
  Files          22       22              
  Lines        2515     2523       +8     
==========================================
+ Hits         2270     2278       +8     
  Misses        245      245              
Flag Coverage Δ
unittests 90.28% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant