-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move legacy boundary to boundary directory #565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
- Coverage 94.25% 94.09% -0.17%
==========================================
Files 82 85 +3
Lines 13077 13235 +158
==========================================
+ Hits 12326 12453 +127
- Misses 751 782 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be too disruptive, but what about not importing these things in boundary/__init__.py
and instead forcing users to import from the legacy module...nevermind that breaks too much backwards compatibility. Looks good.
Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
git diff origin/main **/*py | flake8 --diff
In this PR, I just moved the legacy
boundary.py
to the newboundary
directory named aslegacy_boundary.py