Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move legacy boundary to boundary directory #565

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

ghiggi
Copy link
Contributor

@ghiggi ghiggi commented Dec 8, 2023

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

In this PR, I just moved the legacy boundary.py to the new boundary directory named as legacy_boundary.py

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba09e7d) 94.25% compared to head (a2dcb46) 94.09%.
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   94.25%   94.09%   -0.17%     
==========================================
  Files          82       85       +3     
  Lines       13077    13235     +158     
==========================================
+ Hits        12326    12453     +127     
- Misses        751      782      +31     
Flag Coverage Δ
unittests 94.09% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiggi
Copy link
Contributor Author

ghiggi commented Dec 8, 2023

@mraspaud @djhoese this is ready for review

@coveralls
Copy link

coveralls commented Dec 8, 2023

Coverage Status

coverage: 93.675% (+0.004%) from 93.671%
when pulling a2dcb46 on ghiggi:refactor-boundary-class
into c39f51e on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion

pyresample/boundary/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be too disruptive, but what about not importing these things in boundary/__init__.py and instead forcing users to import from the legacy module...nevermind that breaks too much backwards compatibility. Looks good.

Co-authored-by: Martin Raspaud <martin.raspaud@smhi.se>
@ghiggi
Copy link
Contributor Author

ghiggi commented Dec 8, 2023

@djhoese @mraspaud you can merge ;)

@djhoese djhoese merged commit c240c04 into pytroll:main Dec 8, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants