Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __file__ usage in test units for test_files path #563

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

ghiggi
Copy link
Contributor

@ghiggi ghiggi commented Dec 8, 2023

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

Remove __file__ usage in test units for test_files path.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ba09e7d) 94.25% compared to head (de6049b) 94.09%.
Report is 55 commits behind head on main.

Files Patch % Lines
pyresample/test/test_plot.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   94.25%   94.09%   -0.17%     
==========================================
  Files          82       84       +2     
  Lines       13077    13233     +156     
==========================================
+ Hits        12326    12451     +125     
- Misses        751      782      +31     
Flag Coverage Δ
unittests 94.09% <95.65%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 93.674% (+0.003%) from 93.671%
when pulling de6049b on ghiggi:refactor-test-files-path
into c39f51e on pytroll:main.

@ghiggi
Copy link
Contributor Author

ghiggi commented Dec 8, 2023

@mraspaud @djhoese ready for review.
Let me know if you prefer to have test_files_path lower case or upper case, and if to be located in test/conftest or test/utils

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud
Copy link
Member

mraspaud commented Dec 8, 2023

@mraspaud @djhoese ready for review. Let me know if you prefer to have test_files_path lower case or upper case, and if to be located in test/conftest or test/utils

For me it's good as it is.

@mraspaud mraspaud merged commit 78b19ca into pytroll:main Dec 8, 2023
20 of 21 checks passed
@djhoese
Copy link
Member

djhoese commented Dec 8, 2023

My one comment which is the same as in the other PR is that I think should should have been a Path object. Path(__file__).resolve().parent(). Otherwise, good enough.

@mraspaud
Copy link
Member

mraspaud commented Dec 8, 2023

Sorry, I merged too fast

@ghiggi ghiggi deleted the refactor-test-files-path branch December 8, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants