-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove __file__
usage in test units for test_files
path
#563
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 94.25% 94.09% -0.17%
==========================================
Files 82 84 +2
Lines 13077 13233 +156
==========================================
+ Hits 12326 12451 +125
- Misses 751 782 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
My one comment which is the same as in the other PR is that I think should should have been a Path object. |
Sorry, I merged too fast |
git diff origin/main **/*py | flake8 --diff
Remove
__file__
usage in test units fortest_files
path.