Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citation information #314

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Add citation information #314

merged 5 commits into from
Mar 3, 2021

Conversation

cgentemann
Copy link
Contributor

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff
  • Fully documented

cgentemann and others added 2 commits November 24, 2020 19:39
added citation file
added badge to readme.md
also added citation in readme text
@djhoese
Copy link
Member

djhoese commented Nov 25, 2020

Thanks!

Could you explain how this zenodo json file works? Does zenodo use that to fill in its entry for pyresample or did zenodo generate this file for you?

Side note: We should probably find a way to remove stickler bot from the authors list.

@cgentemann
Copy link
Contributor Author

;) yes, probably remove stickler bot from the authors list... ;)
I have mixed feelings about the .zenodo.json file. It allows you to add metadata to the zenodo record.
So, it is good because it links to orcids, institutions, you can put grant funding, etc.
It is bad because it will have to be updated for each release.
I'm okay with not including if you feel like it might be hard to maintain.
Chelle

@djhoese
Copy link
Member

djhoese commented Nov 25, 2020

It is bad because it will have to be updated for each release.

Aw, really? Yeah that's kind of a pain then. I like all the affiliation stuff, but don't want to have to update the version number and stuff every release. It is weird that it doesn't just supplement the information automatically gathered, but 🤷‍♂️

I think I'm 👎 on it then. @pytroll/core Opinions?

@cgentemann
Copy link
Contributor Author

@pytroll/core Opinions? I don't undestand.

@djhoese
Copy link
Member

djhoese commented Nov 25, 2020

I'm asking the other pytroll (pyresample) maintainers what they think is best.

@sfinkens
Copy link
Member

sfinkens commented Nov 25, 2020

Good initiative! I see that satpy already has a zenodo badge. I guess this is done using webhooks instead of json files? https://guides.github.com/activities/citable-code/ .

@djhoese
Copy link
Member

djhoese commented Nov 25, 2020

@sfinkens The badge in satpy was manually added. Zenodo automatically finds github releases once it is told to look for them. Pyresample has already had a zenodo DOI (99% sure) but it was never linked in the README.

@sfinkens
Copy link
Member

Yes indeed: https://zenodo.org/record/4270378 . Then let's just add the badge :)

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhoese
Copy link
Member

djhoese commented Mar 3, 2021

This is only README changes and I don't want to forget about this PR again so I'm merging it before the tests pass.

@djhoese djhoese changed the title add citation information Add citation information Mar 3, 2021
@djhoese djhoese self-assigned this Mar 3, 2021
@djhoese djhoese merged commit 55d2dbb into pytroll:master Mar 3, 2021
@coveralls
Copy link

coveralls commented Mar 3, 2021

Coverage Status

Coverage decreased (-0.1%) to 92.571% when pulling 0e5a86d on cgentemann:master into bc1cdc7 on pytroll:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants