Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruff formatting & linting #169

Merged
merged 8 commits into from
Jan 31, 2025
Merged

Add Ruff formatting & linting #169

merged 8 commits into from
Jan 31, 2025

Conversation

NiklasRosenstein
Copy link
Collaborator

@NiklasRosenstein NiklasRosenstein commented Jan 30, 2025

This PR adds Ruff as a development dependency and uses it in CI to check for lints and to enforce formatting.

@NiklasRosenstein NiklasRosenstein marked this pull request as ready for review January 30, 2025 21:14
@NiklasRosenstein
Copy link
Collaborator Author

NiklasRosenstein commented Jan 30, 2025

Seems you gave me permissions to merge without waiting for your review, @marzzzello. I'll wait anyway to be sure. 🙂

Side note, I've just changed the settings to disable merge commits and rebase merging and leave only squash merging. It results in a much leaner commit history. Lmk if you dislike that

@NiklasRosenstein NiklasRosenstein added the enhancement New feature or request label Jan 30, 2025
@RealCLanger
Copy link
Collaborator

RealCLanger commented Jan 31, 2025

Cool, I think this looks so much nicer than using "black".

However, in the readme, we have a reference to black:
https://github.com/pytr-org/pytr?tab=readme-ov-file#linting-and-code-formatting

Can you mention ruff there and, if it conflicts (which I believe it does), maybe drop black there?

@NiklasRosenstein
Copy link
Collaborator Author

Indeed, thanks for the notice. I've updated the README now

@NiklasRosenstein NiklasRosenstein merged commit 92b9895 into master Jan 31, 2025
2 checks passed
@NiklasRosenstein NiklasRosenstein deleted the nr/linting branch January 31, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants