Re-subscribe in case of an error from Trade Republic #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this should fix an issue that was initially reported in #109.
When downloading large numbers of timeline events, some subscriptions might yield errors. Such as shown in the logs:
Received error message: '829 E {"errors":[{"errorCode":"UNKNOWN_ERROR","errorField":null,"errorMessage":"Could not process response","meta":{"source":"MAPPER"}}]}'
I guess formerly it caused the downloading not to return at all. This endless waiting seems to have been fixed in 2f62b09. However, this only makes pytr return at the cost of adding some double transactions in the resulting account_transactions.csv while leaving out the transactions where data retrieval from TR failed, because the loop in DL.dl_loop() is not broken up but rather feeded with the previous response.
This should fix it by re-registering failed subscriptions. In my case I now get consistent transaction files when downloading my whole history.