Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-subscribe in case of an error from Trade Republic #133

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

RealCLanger
Copy link
Contributor

Hi,

this should fix an issue that was initially reported in #109.

When downloading large numbers of timeline events, some subscriptions might yield errors. Such as shown in the logs:
Received error message: '829 E {"errors":[{"errorCode":"UNKNOWN_ERROR","errorField":null,"errorMessage":"Could not process response","meta":{"source":"MAPPER"}}]}'

I guess formerly it caused the downloading not to return at all. This endless waiting seems to have been fixed in 2f62b09. However, this only makes pytr return at the cost of adding some double transactions in the resulting account_transactions.csv while leaving out the transactions where data retrieval from TR failed, because the loop in DL.dl_loop() is not broken up but rather feeded with the previous response.

This should fix it by re-registering failed subscriptions. In my case I now get consistent transaction files when downloading my whole history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants