Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache flash attention tracing #8026

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Cache flash attention tracing #8026

merged 1 commit into from
Sep 17, 2024

Conversation

JackCaoG
Copy link
Collaborator

need to add more tests.

alanwaketan
alanwaketan approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JackCaoG JackCaoG marked this pull request as ready for review September 17, 2024 00:22
@JackCaoG JackCaoG merged commit 8b93611 into master Sep 17, 2024
23 checks passed
@JackCaoG JackCaoG deleted the JackCaoG/cache_flash_attention_tracing branch September 17, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwaketan alanwaketan alanwaketan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackCaoG @alanwaketan