Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f8e5m2 support #7924

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

aws-satyajith
Copy link

Notes

Previously, I created a PR to add support for F8E4M3FN: #7898

This extends the same code to add support for an additional FP8 data type: F8E5M2

Based my code changes on this CR: #7740 (Thanks @lsy323 for all FP8 code additions to mainline)

Testing

Added unit tests to cover f8e5m2

@JackCaoG JackCaoG requested a review from lsy323 August 29, 2024 16:30
@jeffhataws
Copy link
Collaborator

@JackCaoG @lsy323 this is backport of 1ed2626 to our 2.1 branch, for testing.

@JackCaoG
Copy link
Collaborator

@lsy323 can you take a look at this one?

@lsy323 lsy323 merged commit 7f2289c into pytorch:r2.1_aws_neuron Aug 29, 2024
1 check passed
@miladm miladm added the fp8 label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants