Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make libtpu install more explict #7737

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

JackCaoG
Copy link
Collaborator

fix #7731

The libtpu install can be more explicit

@JackCaoG
Copy link
Collaborator Author

@will-cromar can you take a look at this pr?

@@ -34,6 +34,7 @@ To install PyTorch/XLA nightly build in a new TPU VM:
```
pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cpu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding #7697 (comment), can you also add an optional command at the end to install compatible torchaudio, torchtext, and torchvision from the PyTorch nightly index?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we rarely ever need torchaudio or torchtext. I think we put torchvision here because I use resnet in my examples.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll follow up on this since it's tangential to this PR's topic. IMO it's still useful to include the other official ecosystem packages. It's very easy to break nightly torch_xla by installing a stable torchtext that pulls in an incompatible stable torch. We've made this mistake numerous times in our own test cases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to install torchaudio, torchtext, etc. from the PyTorch nightly index, the command from PyTorch index page https://screenshot.googleplex.com/8xKE2QXabRsqq9D is pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cpu. They should be compatible already.

@JackCaoG JackCaoG requested a review from will-cromar July 26, 2024 21:49
@JackCaoG
Copy link
Collaborator Author

@will-cromar can you take another look?

@JackCaoG JackCaoG merged commit 009e31a into master Jul 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libtpu not installed with nightly build
3 participants