Type annotation for benchmarks/ #7289

zpcore · 2024-06-15T00:17:57Z

Type annotations for benchmarks/.

Also relocated some functions due to circular import.

ysiraichi

Nice PR. I have pointed out a few places where type hints are still missing.
One additional comment: I think it would be better to update the PR title, so that it represents what you are doing here. It doesn't really fixes any document, does it?

benchmarks/benchmark_experiment.py

benchmarks/benchmark_model.py

benchmarks/experiment_runner.py

benchmarks/util.py

benchmarks/experiment_runner.py

benchmarks/benchmark_experiment.py

benchmarks/result_analyzer.py

benchmarks/torchbench_model.py

vanbasten23 · 2024-06-18T17:35:30Z

Mostly LGTM with minor comments. Thanks!

benchmarks/benchmark_experiment.py

benchmarks/benchmark_model.py

benchmarks/experiment_runner.py

ysiraichi · 2024-06-18T18:44:21Z

Are we also going to start using mypy?

zpcore · 2024-06-18T21:12:04Z

mypy

@will-cromar and @JackCaoG to see if we have such plan.

vanbasten23 · 2024-06-20T17:09:17Z

benchmarks/benchmark_experiment.py

@@ -70,7 +72,9 @@ def _expand_config_choices(self, config_choices):
      configs = new_configs
    return configs

-  def _is_available(self, experiment_config):
+  def _is_available(self,
+                    experiment_config: List[Dict[str,


lol, our benchmark script is complicated

zpcore force-pushed the piz/clean_doc branch 2 times, most recently from a84f2b2 to ba4603d Compare June 16, 2024 07:05

zpcore marked this pull request as ready for review June 16, 2024 07:08

zpcore requested a review from ysiraichi June 16, 2024 07:44

ysiraichi reviewed Jun 17, 2024

View reviewed changes

zpcore changed the title ~~doc fix~~ Type annotation for benchmarks/ Jun 17, 2024

zpcore requested a review from vanbasten23 June 18, 2024 01:07

zpcore enabled auto-merge (squash) June 18, 2024 01:07