Warn when using persistent cache with debug env vars #7175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
reviewed
Jun 3, 2024
torch_xla/csrc/runtime/env_hash.cc
Outdated
| @@ -93,7 +93,7 @@ torch::lazy::hash_t HashXlaEnvVars() { | |||
| // Both XLA_FLAGS and LIBTPU_INIT_ARGS contain XLA flags which impact | |||
| // the compilation result. | |||
| static std::vector<std::string> flag_vars = {"XLA_FLAGS", "LIBTPU_INIT_ARGS"}; | |||
| static std::vector<std::string> raw_vars = {"TPU_MEGACORE"}; | |||
| static std::vector<std::string> raw_vars = {"TPU_MEGACORE", "XLA_HLO_DEBUG"}; | |||
There was a problem hiding this comment.
can we also include XLA_IR_DEBUG? This flag will add additional meta data to the HLO.
There was a problem hiding this comment.
Ah I see, I didn't think XLA_IR_DEBUG would touch the HLO, I'll include both env vars here.
jonb377
changed the title
JackCaoG
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #7169
When using the persistent compilation cache, modifications to the HLO metadata will not impact the graph hash, and the persistent cache will load executables compiled with potentially outdated metadata.
This change:
XLA_HLO_DEBUGorXLA_IR_DEBUGis setXLA_HLO_DEBUGorXLA_IR_DEBUGset.