Fix div lowering and core aten test script enhancement #6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsy323
requested review from
bhavya01 and
wonjoolee95
and removed request for
bhavya01
JackCaoG
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
@vanbasten23 as you are thinking about doing the same thing. We should also cherry-pick this into 2.3 branch as this is a regression.
lsy323
changed the title
wonjoolee95
approved these changes
Apr 2, 2024
bhavya01
approved these changes
Apr 2, 2024
lsy323
added a commit
that referenced
this pull request
Apr 3, 2024
Co-authored-by: Siyuan Liu <lsiyuan@google.coim>
This was referenced Apr 3, 2024
lsy323
added a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch.allclosewould broadcast the operands (e.g.torch.allclose([3, 1], [4])would broadcast both operands to[3,4]and then compare). Add shape check beforetorch.allclose