Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch for unbounded dynamism #6783

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

ghpvnist
Copy link
Collaborator

@ghpvnist ghpvnist commented Mar 20, 2024

Some binary ops return types whose element type differs from the operand element types (e.g. Ne). While broadcasting, it should use the element type of the operand instead of the inferred type.

The fix for this is currently in flight, and the patch will be removed in the next pin update once those changes land.

@ghpvnist ghpvnist requested a review from lsy323 March 20, 2024 18:53
@ghpvnist ghpvnist force-pushed the gunhyun/patch branch 5 times, most recently from 5fd7893 to d9743e9 Compare March 20, 2024 19:57
@lsy323
Copy link
Collaborator

lsy323 commented Mar 20, 2024

LGTM. Thanks @ghpvnist! Would you please update the PR description and specify the patch will be removed in the next pin? Let's merge after CI Passes

@lsy323 lsy323 added the dynamism Dynamic Shape Features label Mar 20, 2024
@lsy323 lsy323 merged commit 8d579f9 into pytorch:master Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dynamism Dynamic Shape Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants